[PATCH] D57393: [InlineAsm][X86] Add backend support for X86 flag output parameters.

[Nirav Dave via Phabricator via llvm-commits]

niravd closed this revision.
niravd added a comment.

Landed in r353307.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7898
+        Val = OpInfo.AssignedRegs.getCopyFromRegs(
+            DAG, FuncInfo, getCurSDLoc(), Chain, &Flag, CS.getInstruction());
+        break;
----------------
thopre wrote:
> Previous code was using IA (that is the output of getCalledValue on the CallSite) rather than the instruction. From what I saw your change is correct as this parameter only gets used indirectly in diagnosePossiblyInvalidConstraint which expects an instruction. Can you confirm?
Your understanding matches mine. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57393/new/

https://reviews.llvm.org/D57393