[PATCH] D57738: [llvm-objcopy] Add --redefine-syms

Wed Feb 6 07:37:39 PST 2019

jhenderson added a comment.

In D57738#1387113 <https://reviews.llvm.org/D57738#1387113>, @evgeny777 wrote:

> > I was actually referring to --redefine-syms, i.e. how it looks in a file. Did you mean "not allow" rather than "now allow" in that other statement?
>
> Yes, that's a mistype. I intended to say GNU objcopy  does NOT allow single name on a line in a file when --redefine-syms is used. So there seems to be no way to set empty name in this mode.
>  We can either duplicate this behavior in llvm-objcopy or show warning like this
>
>   llvm-objcopy: warning: symbol-list:1: missing new symbol name
>

I like the warning, especially if it has the line number in of the offending line(s).

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57738/new/

https://reviews.llvm.org/D57738