[PATCH] D57757: [scudo][standalone] Do not error out on spurious C(XX) flags

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 06:43:01 PST 2019


cryptoad added a comment.

In D57757#1386029 <https://reviews.llvm.org/D57757#1386029>, @eugenis wrote:

> Does the problem appear when -stdlib is passed through custom CFLAGS? I think it is common to disable WERROR as well in that case, or add -Wno-unused-command-line-argument to custom CFLAGS.


So to summarize, remove Werror and let it be handled by COMPILER_RT_ENABLE_WERROR.
And if someone wants to enable COMPILER_RT_ENABLE_WERROR, then it's up to them to deal with spurious command line flag?


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57757/new/

https://reviews.llvm.org/D57757





More information about the llvm-commits mailing list