[PATCH] D57774: [GlobalISel][NFC] Gardening: Factor out code for simple unary intrinsics

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 06:08:09 PST 2019


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with nit



================
Comment at: lib/CodeGen/GlobalISel/IRTranslator.cpp:791
 
+Optional<unsigned>
+IRTranslator::getSimpleUnaryIntrinsicOpcode(Intrinsic::ID IntrinsicID) {
----------------
I don't think it's necessary to use Optional here, since you can use Intrinsic::not_intrinsic and that's what places usually do


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57774/new/

https://reviews.llvm.org/D57774





More information about the llvm-commits mailing list