[PATCH] D57748: AMDGPU: Add inverse ballot intrinsic

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 05:40:28 PST 2019


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInstructions.td:595
 
+
 //===----------------------------------------------------------------------===//
----------------
extra whitespace change


================
Comment at: lib/Target/AMDGPU/SILowerI1Copies.cpp:651-652
 
+      if (MI.getOpcode() == AMDGPU::S_INV_BALLOT)
+        MI.setDesc(TII->get(AMDGPU::COPY));
+
----------------
Can you handle this in EmitInstrWithCustomInserter instead? You'll need to set usesCustomInserter on the instruction


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57748/new/

https://reviews.llvm.org/D57748





More information about the llvm-commits mailing list