[PATCH] D57321: Fix LexFloatLiteral Lexing

[Brandon Jones via Phabricator via llvm-commits]

BrandonTJones marked an inline comment as done.
BrandonTJones added inline comments.


================
Comment at: llvm/lib/MC/MCParser/AsmLexer.cpp:343
+      return LexFloatLiteral(false);
     }
 
----------------
efriedma wrote:
> If we conclude the suffix doesn't qualify as a float, we apparently treat it the suffix as an identifier; is that right?  Are the resulting diagnostics really going to be understandable?  (I guess "unexpected token in '.double' directive" is okay, although not great.)
> 
> Should we worry about binutils compatibility at all?  It apparently treats `1.e` as equivalent to `1.e0`.
I think the diagnostics should be okay.

For binutils compat, does it treat no exponent as "0" always, or only in the case of <digits>.e. 
There seem to be tests in place that expect the program to die in response to these cases instead of handling them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57321/new/

https://reviews.llvm.org/D57321