[PATCH] D57510: [DebugInfo] Keep parameter DBG_VALUEs before prologue code

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 04:26:18 PST 2019


dstenb added inline comments.


================
Comment at: lib/CodeGen/PrologEpilogInserter.cpp:184
+    if (!MI.isDebugValue() || !MI.getDebugVariable()->isParameter())
+      continue;
+    if (MI.getOperand(0).isFI()) {
----------------
aprantl wrote:
> Nevermind. The new labels probably.
Yes, this is for labels. In the cases I have looked at, the `DBG_LABEL` instructions are placed after the parameter `DBG_VALUE` instructions, but I guess there might cases where they are intermixed, or it could change in the future so that the labels are placed before.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57510/new/

https://reviews.llvm.org/D57510





More information about the llvm-commits mailing list