[PATCH] D56075: [GuardWidening] Support widening of explicitly expressed guards

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev marked an inline comment as done.
mkazantsev added inline comments.


================
Comment at: test/Transforms/GuardWidening/basic_explicit_guards.ll:5
+
+declare void @llvm.experimental.guard(i1, ...)
+
----------------
mkazantsev wrote:
> reames wrote:
> > This declaration is unused.  Can you fix that by adding at least two tests mixing guards and widenable conditions?  (i.e. one each widening from the other)
> These tests have already be derived from `test/Transforms/GuardWidening/basic.ll` Does it make sense to duplicate?
i.e. these tests are directly derived from tests from basic.ll using `MakeGuardsExplicit` pass. I'm not sure that it makes sense to have them in two files at the same time.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56075/new/

https://reviews.llvm.org/D56075