[PATCH] D57245: [PPC64] Sort .toc sections accessed with small code model relocs close to the .got part 2

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 6 03:14:18 PST 2019


MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.
Herald added a project: LLVM.


================
Comment at: ELF/Relocations.cpp:1005
+  // relocation overflows) we need only to identify those small code model
+  // relocations that will access the .toc section. The got based small code
+  // model relocations inform the linker to create a got entry (or entries) and
----------------
The description of GOT is verbose.. and I don't get why it is not necessary for small code model sorting.

(Glad to know that we don't need a ton of GOT relocations used in binuitls-gdb: R_PPC64_GOT_TLSLD16 R_PPC64_GOT_TPREL16_DS R_PPC64_GOT16 ...)

Than change LG.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57245/new/

https://reviews.llvm.org/D57245





More information about the llvm-commits mailing list