[PATCH] D57805: [HotColdSplit] Move splitting after instrumented PGO use

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson created this revision.
tejohnson added reviewers: vsk, hiraditya, sebpop.
Herald added a subscriber: mehdi_amini.
Herald added a project: LLVM.

Follow up to D57082 <https://reviews.llvm.org/D57082> which moved splitting earlier in the pipeline, in
order to perform it before inlining. However, it was moved too early,
before the IR is annotated with instrumented PGO data. This caused the
splitting to incorrectly determine cold functions.

Move it to just after PGO annotation (still before inlining), in both
pass managers.


Repository:
  rL LLVM

https://reviews.llvm.org/D57805

Files:
  lib/Passes/PassBuilder.cpp
  lib/Transforms/IPO/PassManagerBuilder.cpp
  test/Other/Inputs/pass-pipelines.proftext
  test/Other/new-pm-pgo.ll
  test/Other/pass-pipelines.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57805.185481.patch
Type: text/x-patch
Size: 6221 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190206/5143fde5/attachment.bin>