[PATCH] D57533: lit: support long paths on Windows

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

https://bugs.chromium.org/p/chromium/issues/detail?id=603364 is our old bug on that. Getting the right mix of win gnu tools is tricky either way (…though people can just pull the latest gnuwin zip from http://commondatastorage.googleapis.com/chromium-browser-clang/index.html?path=tools/ I suppose). Saying "we require an rm that can handle long path names" doesn't strike me as unreasonable.

The progression here was:

1. Require rm to be present
2. Switch to a built-in rm that doesn't work
3. Reimplement a long-path rm in the built-in

That seems a bit like we're working hard to solve problems we made ourselves – imho we should just backtrack on step 2.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57533/new/

https://reviews.llvm.org/D57533