[PATCH] D57382: [LV] Move interleave count computation to LVP::plan().

Tue Feb 5 15:48:31 PST 2019

hsaito added a comment.

In D57382#1386147 <https://reviews.llvm.org/D57382#1386147>, @fhahn wrote:

> As it is at the moment, we need to know the selected vectorization factor to compute the interleave count. And we need to know the interleave count to know if we need to generate VPlans. Maybe with this refactor it would also make sense to only generate a VPlan for the selected vectorization factor for now? There is no need to build VPlans for multiple vectorization factors in the legacy planning and we have the VPlan native path which builds the VPlans up front for planning.

I don't disagree with you in principle, but let's wait until planInVPlanNativePath() actually starts to build VPlans for multiple VFs. I hate to see the rest of the things getting bit rotten before that happens.
This is partly because I haven't worked on the legacy side of CM running on VPlan as much as I should --- so, I can't complain. Once that version of CM is ready, once again, I'll have to build multiple VPlans.
Please be forewarned.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57382/new/

https://reviews.llvm.org/D57382