[PATCH] D57791: [WebAssembly] memory.fill and finish bulk memory

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 15:24:14 PST 2019


sbc100 added a comment.

Nice!  I like the use of .s file for testing too!



================
Comment at: llvm/test/MC/WebAssembly/bulk-memory-encodings.s:18
+
+    end_function
----------------
I think this should just be `end`.  I think  end_* variants are supposed to be internal.  Might want to check with wouter though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57791/new/

https://reviews.llvm.org/D57791





More information about the llvm-commits mailing list