[PATCH] D57720: [sanitizer] Decorate /proc/self/maps on Android.

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 15:21:21 PST 2019


eugenis added a comment.

In D57720#1386140 <https://reviews.llvm.org/D57720#1386140>, @pcc wrote:

> The GetNamedMappingFd and DecorateMapping APIs seem a little awkwards to me. Everyone is using them as  GetNamedMappingFd/mmap/DecorateMapping except for one place in hwasan. Would it make more sense to have a single function that does GetNamedMappingFd/mmap/DecorateMapping and continue using PR_SET_VMA_ANON_NAME in hwasan?


Yes, this is way better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57720/new/

https://reviews.llvm.org/D57720





More information about the llvm-commits mailing list