[PATCH] D57625: [TargetLibraryInfo] Update run time support for Windows

Evandro Menezes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 15:18:02 PST 2019


evandro marked an inline comment as done.
evandro added inline comments.


================
Comment at: llvm/lib/Analysis/TargetLibraryInfo.cpp:165
+                         T.getArch() == Triple::arm ||
+                         T.getArch() == Triple::x86_64);
+
----------------
evandro wrote:
> rnk wrote:
> > I think you can use `T.getEnvironmentVersion()` here to get the MSVC version. Maybe make it conditional on `isWindowsMSVCEnvironment()`. If there is no version or it isn't an MSVC environment, just assume full C99 support is available (i.e. the UCRT is in use).
> What's the correlation between MSVCRT major version and VS release year?
FWIW, LLVM seems to be aware only of major versions 18 and 19, according to test cases.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57625/new/

https://reviews.llvm.org/D57625





More information about the llvm-commits mailing list