[PATCH] D57790: [CodeView] Fix cycles in debug info when merging Types with global hashes
Alexandre Ganea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 5 14:55:02 PST 2019
aganea marked an inline comment as done.
aganea added inline comments.
================
Comment at: include/llvm/DebugInfo/CodeView/TypeHashing.h:119
+ }
+ if (ReqSecondPass) {
+ auto HashIt = Hashes.begin();
----------------
rnk wrote:
> I think this would have to go to fix point, not just two passes. Consider the case where each record in the type stream refers to the next, i.e. a pointer to a pointer to a pointer ... to void, and everything is backwards. =(
Good point. I can make a test case, and modify to handle that.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57790/new/
https://reviews.llvm.org/D57790
More information about the llvm-commits
mailing list