[PATCH] D57757: [scudo][standalone] Do not error out on spurious C(XX) flags

[Kostya Kortchinsky via Phabricator via llvm-commits]

cryptoad added inline comments.


================
Comment at: lib/scudo/standalone/CMakeLists.txt:14
+if(COMPILER_RT_ENABLE_WERROR)
+  append_string_if(COMPILER_RT_HAS_WERROR_FLAG -Wno-unused-command-line-argument SCUDO_CFLAGS)
+endif()
----------------
eugenis wrote:
> Did you mean to add -Werror here instead of -Wno-unused-command-line-argument?
> COMPILER_RT_HAS_WERROR_FLAG only means that -Werror is supported, not the other one.
It seems to be already added in compiler-rt/CMakeLists.txt:
```
if(COMPILER_RT_ENABLE_WERROR)
  append_string_if(COMPILER_RT_HAS_WERROR_FLAG -Werror CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
```
AFAIU the cmake flags will be in the final command line.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57757/new/

https://reviews.llvm.org/D57757