[PATCH] D57749: [LLD][ELF] - Set DF_STATIC_TLS flag for i386 target.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 12:00:04 PST 2019


grimar added a comment.

In D57749#1385666 <https://reviews.llvm.org/D57749#1385666>, @joerg wrote:

> The description is certainly not right. IE can be used from dlopen'd objects without problems as long as there is still reserved space around and the data is not initialized non-trivially or the dynamic linker is willing to fix up all threads. The point of the flag is to allow the dynamic linker to make a quick decision without having to scan the relocation table first. A classic user of this was libGL. It also applies to many platforms, not just i386. As such, please update the description before any commit.


I updated the description to say just "DF_STATIC_TLS flag indicates that the shared object or executable contains code using a static thread-local storage scheme."
i386 was mentioned only because this patch does that for this target only.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57749/new/

https://reviews.llvm.org/D57749





More information about the llvm-commits mailing list