[PATCH] D57157: [DEBUG_INFO][NVPTX] Generate DW_AT_address_class to get the values in debugger.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev marked an inline comment as done.
ABataev added inline comments.


================
Comment at: include/llvm/IR/DebugInfoMetadata.h:2516
+  /// Space>.
+  static const DIExpression *extractAddressClass(const DIExpression *Expr,
+                                                 unsigned &AddrClass);
----------------
ABataev wrote:
> aprantl wrote:
> > I understand that you copied the interface from the function above, but could you please make it
> > 
> > `Optional<unsigned> getAddressClass() const;`
> > 
> > instead?
> > 
> > We should also change extractIfOffset this way...
> I cannot make it `const`, it modifies the expression itself and should build the new expression if the pattern is found.
I mean, it should(!) modify the expression itself, but I can not do it, because this function is applied to the constant expressions.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57157/new/

https://reviews.llvm.org/D57157