[PATCH] D57749: [LLD][ELF] - Set DF_STATIC_TLS flag for i386 target.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 5 10:58:31 PST 2019
ruiu added a comment.
Could you give me a pointer to the FreeBSD change to support this feature?
================
Comment at: ELF/Arch/X86.cpp:80
+ Type == R_386_TLS_GOTIE)
+ Config->HasStaticTlsModel = true;
+
----------------
I don't remember if this function is called from a multi-threaded part of lld. If that's the case, mutating a variable is not considered thread-safe, even if you are just mutating a boolean variable and set it to the same value from everywhere.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57749/new/
https://reviews.llvm.org/D57749
More information about the llvm-commits
mailing list