[PATCH] D57157: [DEBUG_INFO][NVPTX] Generate DW_AT_address_class to get the values in debugger.

Tue Feb 5 10:46:39 PST 2019

ABataev marked 2 inline comments as done.
ABataev added a comment.

Adrian, thanks a lot for the review!

================
Comment at: lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:112

+static Optional<unsigned> getAddressClass(const DIExpression &Expr) {
+  if (Expr.getNumElements() == 4 && Expr.getElement(0) == dwarf::DW_OP_constu &&
----------------
aprantl wrote:
> This should be a member function of DIExpression instead. We have other similar properties there already.
Made it a static member function instead of the `DIExpression` class. Need to modify the expression by deleting the last 4 elements after AddressClass extraction, but function is applied to const expressions. Need to create the new expression, if the pattern was recognized.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57157/new/

https://reviews.llvm.org/D57157