[PATCH] D57738: [llvm-objcopy] Add --redefine-syms

[Eugene Leviant via Phabricator via llvm-commits]

evgeny777 marked an inline comment as done.
evgeny777 added inline comments.


================
Comment at: tools/llvm-objcopy/CopyConfig.cpp:259
+      auto Pair = TrimmedLine.split(' ');
+      SymbolsToRename.insert({Pair.first, Pair.second.trim()});
+    }
----------------
rupprecht wrote:
> This needs StringSaver to retain these lines once the memory buffer has gone out of scope.
> 
> I'm able to reproduce a crash w/ asan by removing `StringSaver` from `addGlobalSymbolsFromFile` above, and the usage here looks similar.
Yep, good catch


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57738/new/

https://reviews.llvm.org/D57738