[PATCH] D57510: [DebugInfo] Keep parameter DBG_VALUEs before prologue code

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/CodeGen/PrologEpilogInserter.cpp:174
+
+/// Stash DBG_VALUEs that describe parameters and which are placed at the start
+/// of the block.
----------------
Can you add a sentence explaining what stashing is for, something like "... the stashed DBG_VALUEs will be processed later by ..."?


================
Comment at: lib/CodeGen/PrologEpilogInserter.cpp:183
+      break;
+    if (!MI.isDebugValue() || !MI.getDebugVariable()->isParameter())
+      continue;
----------------
What kind of DebugInstr in MIR are not also a DebugValue?
Is this condition equivalent to 

`assert(MI.isDebugValue())` ?


================
Comment at: lib/CodeGen/PrologEpilogInserter.cpp:184
+    if (!MI.isDebugValue() || !MI.getDebugVariable()->isParameter())
+      continue;
+    if (MI.getOperand(0).isFI()) {
----------------
Nevermind. The new labels probably.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57510/new/

https://reviews.llvm.org/D57510