[PATCH] D57316: [LoopSimplifyCFG] Work around bug in DTU by using lazy strategy

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 06:57:42 PST 2019


kuhar requested changes to this revision.
kuhar added a comment.
This revision now requires changes to proceed.

In D57316#1384650 <https://reviews.llvm.org/D57316#1384650>, @mkazantsev wrote:

> So, is it OK to go with this fix here?


You should replace insert/deleteEdge with applyUpdates -- I'd argue that even though it works with how the lazy strategy is implemented now, it is incorrect because the DomTree updates you schedule don't match the CFG at the point of updates.
Then, it would be interesting to see whether:

1. Eager strategy works (it should)
2. How fast is eager vs lazy


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57316/new/

https://reviews.llvm.org/D57316





More information about the llvm-commits mailing list