[PATCH] D57329: [gn] Checking in BUILD.gn files for clang-tidy and clang-apply-replacements

[Mirko Bonadei via Phabricator via llvm-commits]

mbonadei added inline comments.


================
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/BUILD.gn:19
+
+    # TODO(mbonadei): FIXME.
+    # ClangSACheckers
----------------
thakis wrote:
> yvesg wrote:
> > What should be fixed? I.e. what is the current limitation?
> > Static Analyzer checks not available? If so, the following deps could be commented.
> +1.
I commented out the two deps below. I will look into it in the next few days (ClangSACheckers uses tablegen and I need to read about it and learn what it does). Is it OK to land this without SACheckers support?


================
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clang-tidy/abseil/BUILD.gn:14
+  sources = [
+    "AbseilTidyModule.cpp",
+    "DurationComparisonCheck.cpp",
----------------
thakis wrote:
> Because it took me so long, this is now missing
> 
>     "DurationAdditionCheck.cpp",
> 
> (courtesy of `llvm/utils/gn/build/sync_source_lists_from_cmake.py` after rebasing locally)
That script is great! It detected two more checks that have been added recently! :)


================
Comment at: llvm/utils/gn/secondary/clang/lib/Basic/BUILD.gn:3
   output_name = "clangBasic"
-  configs += [ "//llvm/utils/gn/build:clang_code" ]
+  public_configs = [ "//llvm/utils/gn/build:clang_code" ]
   public_deps = [
----------------
thakis wrote:
> Instead of this, I think it'd be better to say `configs += [ "//llvm/utils/gn/build:clang_code" ]` in all the clang-tools-extra targets (like all the clang targets do)
I see that we are not declaring headers to gn. Is this something we'll want to have in the future? I think this is related to how we look at `configs` vs `public_configs` as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57329/new/

https://reviews.llvm.org/D57329