[PATCH] D57748: AMDGPU: Add inverse ballot intrinsic

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/llvm.amdgcn.inverse.ballot.ll:18-20
+define amdgpu_ps float @vgpr(i32 %v0, i32 %v1) {
+  %tmp = insertelement <2 x i32> undef, i32 %v0, i32 0
+  %tmp2 = insertelement <2 x i32> %tmp, i32 %v1, i32 1
----------------
You can just use an i64 argument here instead of this build vector and cast thing


================
Comment at: test/CodeGen/AMDGPU/llvm.amdgcn.inverse.ballot.ll:26
+}
+
+declare i1 @llvm.amdgcn.inverse.ballot(i64)
----------------
Need to add a few more tests with more complex situations (particularly one with a uniform phi, and one with a divergent phi)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57748/new/

https://reviews.llvm.org/D57748