[PATCH] D57620: Optimize printf calls that don't use 128-bit floating-point values

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 05:58:07 PST 2019


sunfish marked 2 inline comments as done.
sunfish added inline comments.


================
Comment at: test/Transforms/InstCombine/fprintf-1.ll:5
 ; RUN: opt < %s -mtriple xcore-xmos-elf -instcombine -S | FileCheck %s -check-prefix=CHECK-IPRINTF
+; RUN: opt < %s -mtriple wasm32-unknown-wasi -instcombine -S | FileCheck %s -check-prefix=CHECK-SMALL-PRINTF
 
----------------
sbc100 wrote:
> Do we need signal that this test now requires the webassembly target? 
I don't think so; it doesn't need the whole target, just the triple. I assume this is why the test doesn't signal it needs XCore either, despite using it in the same way here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57620/new/

https://reviews.llvm.org/D57620





More information about the llvm-commits mailing list