[llvm] r353168 - gn build: Fix Python 3 write_vcsrevision script compatibility

Serge Guelton via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 05:01:13 PST 2019


Author: serge_sans_paille
Date: Tue Feb  5 05:01:12 2019
New Revision: 353168

URL: http://llvm.org/viewvc/llvm-project?rev=353168&view=rev
Log:
gn build: Fix Python 3 write_vcsrevision script compatibility

Trivial fix: decode was not called for all subprocess.check_output calls.

Commited on behalf of Andrew Boyarshin

Differential Revision: https://reviews.llvm.org/D57505


Modified:
    llvm/trunk/utils/gn/build/write_vcsrevision.py

Modified: llvm/trunk/utils/gn/build/write_vcsrevision.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/build/write_vcsrevision.py?rev=353168&r1=353167&r2=353168&view=diff
==============================================================================
--- llvm/trunk/utils/gn/build/write_vcsrevision.py (original)
+++ llvm/trunk/utils/gn/build/write_vcsrevision.py Tue Feb  5 05:01:12 2019
@@ -47,7 +47,7 @@ def main():
         use_shell = True
 
     git_dir = subprocess.check_output([git, 'rev-parse', '--git-dir'],
-                                      cwd=LLVM_DIR, shell=use_shell).strip()
+                                      cwd=LLVM_DIR, shell=use_shell).decode().strip()
     if not os.path.isdir(git_dir):
         print('.git dir not found at "%s"' % git_dir, file=sys.stderr)
         return 1




More information about the llvm-commits mailing list