[PATCH] D57505: gn build: Fix Python 3 write_vcsrevision script compatibility

Phabricator via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 05:01:23 PST 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL353168: gn build: Fix Python 3 write_vcsrevision script compatibility (authored by serge_sans_paille, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D57505?vs=184479&id=185286#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57505/new/

https://reviews.llvm.org/D57505

Files:
  llvm/trunk/utils/gn/build/write_vcsrevision.py


Index: llvm/trunk/utils/gn/build/write_vcsrevision.py
===================================================================
--- llvm/trunk/utils/gn/build/write_vcsrevision.py
+++ llvm/trunk/utils/gn/build/write_vcsrevision.py
@@ -47,7 +47,7 @@
         use_shell = True
 
     git_dir = subprocess.check_output([git, 'rev-parse', '--git-dir'],
-                                      cwd=LLVM_DIR, shell=use_shell).strip()
+                                      cwd=LLVM_DIR, shell=use_shell).decode().strip()
     if not os.path.isdir(git_dir):
         print('.git dir not found at "%s"' % git_dir, file=sys.stderr)
         return 1


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57505.185286.patch
Type: text/x-patch
Size: 633 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190205/f173ab1a/attachment.bin>


More information about the llvm-commits mailing list