[PATCH] D57693: [DebugInfo]Print correct value for special opcode address increment

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 03:45:23 PST 2019


jhenderson updated this revision to Diff 185274.
jhenderson added a comment.

Remove unnecessary cast.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57693/new/

https://reviews.llvm.org/D57693

Files:
  lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  test/tools/llvm-dwarfdump/X86/verbose.test


Index: test/tools/llvm-dwarfdump/X86/verbose.test
===================================================================
--- test/tools/llvm-dwarfdump/X86/verbose.test
+++ test/tools/llvm-dwarfdump/X86/verbose.test
@@ -16,7 +16,7 @@
 # CHECK: 0x0000000000000000      1      0      1   0             0  is_stmt
 # CHECK: 05 DW_LNS_set_column (12)
 # CHECK: 0a DW_LNS_set_prologue_end
-# CHECK: 66 address += 89,  line += 0
+# CHECK: 66 address += 6,  line += 0
 # CHECK: 0x0000000000000006      1     12      1   0             0  is_stmt prologue_end
 # CHECK: 02 DW_LNS_advance_pc (2)
 # CHECK: 00 DW_LNE_end_sequence
Index: lib/DebugInfo/DWARF/DWARFDebugLine.cpp
===================================================================
--- lib/DebugInfo/DWARF/DWARFDebugLine.cpp
+++ lib/DebugInfo/DWARF/DWARFDebugLine.cpp
@@ -817,8 +817,8 @@
       State.Row.Address += AddrOffset;
 
       if (OS) {
-        *OS << "address += " << ((uint32_t)AdjustOpcode)
-            << ",  line += " << LineOffset << "\n";
+        *OS << "address += " << AddrOffset << ",  line += " << LineOffset
+            << "\n";
         OS->indent(12);
         State.Row.dump(*OS);
       }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57693.185274.patch
Type: text/x-patch
Size: 1166 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190205/115f1974/attachment.bin>


More information about the llvm-commits mailing list