[PATCH] D57691: [yaml2obj][obj2yaml] - Add support for dumping/parsing .dynamic sections.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 5 00:07:55 PST 2019


grimar added a comment.

In D57691#1383238 <https://reviews.llvm.org/D57691#1383238>, @jhenderson wrote:

> @amontanez has already put something similar up for review here as D56569 <https://reviews.llvm.org/D56569>.
>
> There was a corresponding llvm-dev email thread to discuss it further here:
>  http://lists.llvm.org/pipermail/llvm-dev/2019-January/129231.html
>
> which didn't get much traction.


Interesting. I did not see it. D56569 <https://reviews.llvm.org/D56569> seems to do a lot of different things.

FTR, my main intentions were the following:

1. I looked how to dump/parse ELF versioning sections and found we sometimes might want to access

the dynamic tags values. For example:

DT_VERDEFNUM  // The number of entries in DT_VERDEF.
DT_VERNEEDNUM // The number of entries in DT_VERNEED.

2. I noticed that some of our tests (For example, "binary-read-bad-vaddr.test" and lots of others improved by this patch)

want to see the particular tags and values and there was no way to do that (without editing the raw binary section content).

So I decided to implement the simple solution that would allow accessing and changing the dynamic entries from yaml and the code.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57691/new/

https://reviews.llvm.org/D57691





More information about the llvm-commits mailing list