[PATCH] D57727: [WebAssembly] Lower memmove to memory.copy

[Thomas Lively via Phabricator via llvm-commits]

tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblySelectionDAGInfo.h:31
                                   MachinePointerInfo SrcPtrInfo) const override;
+  SDValue EmitTargetCodeForMemmove(SelectionDAG &DAG, const SDLoc &dl,
+                                   SDValue Chain, SDValue Op1, SDValue Op2,
----------------
aheejin wrote:
> aheejin wrote:
> > Let's follow the current variable naming rules until they change. For `isVolatile` and the preivously added memcpy function too, both here and the cpp file.
> I mean, for `isVolatile` and `dl`
Oops, this is left over from copying from the base class header. Goes to show just how uniform the codebase is now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57727/new/

https://reviews.llvm.org/D57727