[PATCH] D57727: [WebAssembly] Lower memmove to memory.copy
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 4 17:10:16 PST 2019
aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.
LGTM % nits
================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblySelectionDAGInfo.h:31
MachinePointerInfo SrcPtrInfo) const override;
+ SDValue EmitTargetCodeForMemmove(SelectionDAG &DAG, const SDLoc &dl,
+ SDValue Chain, SDValue Op1, SDValue Op2,
----------------
Let's follow the current variable naming rules until they change. For `isVolatile` and the preivously added memcpy function too, both here and the cpp file.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57727/new/
https://reviews.llvm.org/D57727
More information about the llvm-commits
mailing list