[PATCH] D44252: [CVP] [LVI] Add LVI::getPredicateInBlock and use it in CVP.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 4 15:51:04 PST 2019


reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

Sorry for just getting around to reviewing this now.  Should be a bit more response now.

Looking at the approach, it appears you're effectively working around a implementation limitation in getPredicateAt.  As an alternative, why not simply extend getPredicateAt to compute facts known at the begining of the block specified by the context pointer, and then merge that with the facts from within the block?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D44252/new/

https://reviews.llvm.org/D44252





More information about the llvm-commits mailing list