[PATCH] D57533: lit: support long paths on Windows

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: utils/lit/lit/TestRunner.py:620
+
+                    class SHFILEOPSTRUCTW(Structure):
+                        _fields_ = [
----------------
This seems like a lot of ctypes code that would be better off written as a little llvm-rm utility in native C++ code, with a substitution from `\brm\b` to `llvm-rm`. Then, we'll have finally integrated a "safe rm" into LLVM, and we'll have a place we can add retry loops to try to satisfy hostile virus scanners.... it'll be great. =P WDYT?


================
Comment at: utils/lit/lit/util.py:139
+            NTPath = unicode(r'\\?\%s' % path)
+            if not windll.CreateDirectoryW(NTPath, None):
+                raise WinError(GetLastError())
----------------
This seems reasonable to leave as python.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57533/new/

https://reviews.llvm.org/D57533