[PATCH] D57522: GlobalISel: Implement narrowScalar for select
Amara Emerson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 4 15:21:35 PST 2019
aemerson accepted this revision.
aemerson added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:2256
+ Src2Regs, Src2LeftoverRegs))
+ llvm_unreachable("inconsistent extractParts result");
+
----------------
I think this should either be an assert or return UnableToLegalize and report a fallback.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57522/new/
https://reviews.llvm.org/D57522
More information about the llvm-commits
mailing list