[PATCH] D57653: GlobalISel: Combine g_extract with g_merge_values

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 4 15:18:48 PST 2019


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

It's not quite true that these combines are required for legalization, but to clean up instructions required to satisfy the type requirements. Operations left over should still be legalized in some way so as to not cause a selection failure later, even if the codegen is poor quality.

Anyway, this is something that was on my todo list anyway, the aarch64 test regression looks ok. We don't want a hasOneUse case because sometimes we can have multiple extracts which we definitely want to replace with copies if we can.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57653/new/

https://reviews.llvm.org/D57653





More information about the llvm-commits mailing list