[llvm] r353094 - gn build: Windows: use a more standard format for PDB filenames
David Major via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 4 13:20:25 PST 2019
Author: dmajor
Date: Mon Feb 4 13:20:25 2019
New Revision: 353094
URL: http://llvm.org/viewvc/llvm-project?rev=353094&view=rev
Log:
gn build: Windows: use a more standard format for PDB filenames
The current build was producing names like llvm-undname.exe.pdb, which looks unusual to me at least. This switches them to the more common llvm-undname.pdb style.
Differential Revision: https://reviews.llvm.org/D57613
Modified:
llvm/trunk/utils/gn/build/toolchain/BUILD.gn
Modified: llvm/trunk/utils/gn/build/toolchain/BUILD.gn
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/build/toolchain/BUILD.gn?rev=353094&r1=353093&r2=353094&view=diff
==============================================================================
--- llvm/trunk/utils/gn/build/toolchain/BUILD.gn (original)
+++ llvm/trunk/utils/gn/build/toolchain/BUILD.gn Mon Feb 4 13:20:25 2019
@@ -50,7 +50,7 @@ template("unix_toolchain") {
# Remove the output file first so that ar doesn't try to modify the
# existing file.
command =
- "rm -f {{output}} && $ar rcsD {{arflags}} {{output}} {{inputs}}"
+ "rm -f {{output}} && $ar rcsDT {{arflags}} {{output}} {{inputs}}"
}
description = "AR {{output}}"
outputs = [
@@ -234,9 +234,11 @@ toolchain("win") {
}
tool("solink") {
- dllfile = "{{output_dir}}/{{target_output_name}}{{output_extension}}"
- libfile = "$dllfile.lib"
- command = "$link /nologo /dll {{ldflags}} /out:$dllfile /implib:$libfile {{libs}} /pdb:$dllfile.pdb {{inputs}}"
+ outprefix = "{{output_dir}}/{{target_output_name}}"
+ dllfile = "$outprefix{{output_extension}}"
+ libfile = "$outprefix.lib"
+ pdbfile = "$outprefix.pdb"
+ command = "$link /nologo /dll {{ldflags}} /out:$dllfile /implib:$libfile /pdb:$pdbfile {{libs}} {{inputs}}"
description = "LINK $dllfile"
link_output = libfile
depend_output = libfile
@@ -259,8 +261,10 @@ toolchain("win") {
# standalone loadable modules used for unit-testing LLVM's dynamic library
# loading code.
tool("solink_module") {
- dllfile = "{{output_dir}}/{{target_output_name}}{{output_extension}}"
- command = "$link /nologo /dll {{ldflags}} /out:$dllfile {{libs}} /pdb:$dllfile.pdb {{inputs}}"
+ outprefix = "{{output_dir}}/{{target_output_name}}"
+ dllfile = "$outprefix{{output_extension}}"
+ pdbfile = "$outprefix.pdb"
+ command = "$link /nologo /dll {{ldflags}} /out:$dllfile /pdb:$pdbfile {{libs}} {{inputs}}"
description = "LINK_MODULE $dllfile"
outputs = [
dllfile,
@@ -272,8 +276,10 @@ toolchain("win") {
}
tool("link") {
- outfile = "{{output_dir}}/{{target_output_name}}{{output_extension}}"
- command = "$link /nologo {{ldflags}} /out:$outfile {{libs}} /pdb:$outfile.pdb {{inputs}}"
+ outprefix = "{{output_dir}}/{{target_output_name}}"
+ outfile = "$outprefix{{output_extension}}"
+ pdbfile = "$outprefix.pdb"
+ command = "$link /nologo {{ldflags}} /out:$outfile /pdb:$pdbfile {{libs}} {{inputs}}"
description = "LINK $outfile"
outputs = [
outfile,
More information about the llvm-commits
mailing list