[PATCH] D57681: [InstCombine] Cleanup the TFE/LWE check in AMDGPU SimplifyDemanded

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle marked an inline comment as done.
nhaehnle added a comment.

In D57681#1383030 <https://reviews.llvm.org/D57681#1383030>, @arsenm wrote:

> Does it actually matter? I thought since this needs to be a constant, this just needs to not crash


It's certainly a bit on the paranoid side. I was considering the possibility that somebody passes a value that only becomes constant after inlining.



================
Comment at: test/Transforms/InstCombine/AMDGPU/amdgcn-demanded-vector-elts.ll:2420
+
+declare {<4 x float>, i32} @llvm.amdgcn.image.load.1d.sl_v4f32i32s.i32(i32, i32, <8 x i32>, i32, i32) #1
+
----------------
arsenm wrote:
> There's an _ in the name?
You mean the `sl_v4f32i32s` part? That's what the intrinsic name got canonicalized to for some reason. I'm not really uptodate on the mangling of struct types...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57681/new/

https://reviews.llvm.org/D57681