[PATCH] D57708: AMDGPU: Don't rematerialize mov with implicit operands
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 4 13:09:41 PST 2019
arsenm marked an inline comment as done.
arsenm added inline comments.
================
Comment at: lib/Target/AMDGPU/SIInstrInfo.cpp:144
+ // No implicit operands.
+ return MI.getNumOperands() == MI.getDesc().getNumOperands();
default:
----------------
rampitec wrote:
> The all have implicit exec. Is that reflected in MI.getDesc().getNumOperands()?
Yes, this is the second meaning of implicit operands (not present in the static instruction definition). I originally hardcoded this to 3
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57708/new/
https://reviews.llvm.org/D57708
More information about the llvm-commits
mailing list