[PATCH] D57666: [LLD] [COFF] Avoid O(n^2) insertion into PartialSections

Mon Feb 4 12:59:39 PST 2019

aganea added a comment.

In D57666#1383852 <https://reviews.llvm.org/D57666#1383852>, @mstorsjo wrote:

> Hmm, I don't really see where PartialSection or the set/map PartialSections are used within that patch at all?

Sorry about the confusion. It was callled `InputSection` in D54802 <https://reviews.llvm.org/D54802>, see lld/trunk/COFF/Writer.h in that patch.

> But even then, if it isn't part of the PartialSection object itself, but only part of the key in the map, can't you get it while iterating over it, like this?

Not for iterating, but for referencing a `PartialSection` from an `OutputSection` for later usage, see lld/trunk/COFF/PDB.cpp, L1509.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57666/new/

https://reviews.llvm.org/D57666