[PATCH] D54802: [LLD][COFF] Generate import modules in PDB

Mon Feb 4 12:50:35 PST 2019

mstorsjo added inline comments.

================
Comment at: lld/trunk/test/COFF/hello32.test:60
 HEADER-NEXT:     ExportTableSize: 0x0
-HEADER-NEXT:     ImportTableRVA: 0x2000
+HEADER-NEXT:     ImportTableRVA: 0x3000
 HEADER-NEXT:     ImportTableSize: 0x28
----------------
aganea wrote:
> mstorsjo wrote:
> > I didn't read the whole patch in detail, but can you give a TL;DR about what's added to the output files in the case when no PDB output is enabled, that shuffles some sections forward now?
> Please see lld/trunk/COFF/Driver.cpp, L1226, I initially removed `parseMerge(".idata=.rdata");`
> 
> And [[ https://reviews.llvm.org/D54802#1309681 | the comment ]] above:
> //"More importantly, link.exe folds .idata sections into .rdata only when /INCREMENTAL:NO is specified. Given that /INCREMENTAL is the default, I thought we should do the same in LLD. I would need to disable that behavior when providing /INCREMENTAL:NO (not in this patch yet)."//
> 
> However, it was decided that we'll keep the current .idata merging behavior for now.
> 
Ok, I see. Thanks!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54802/new/

https://reviews.llvm.org/D54802