[PATCH] D57694: [DebugInfo][DAG] Either salvage dangling debug info or emit Undef DBG_VALUEs

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h:682
 
-  // resolveDanglingDebugInfo - if we saw an earlier dbg_value referring to V,
-  // generate the debug data structures now that we've seen its definition.
+  /// resolveDanglingDebugInfo - if we saw an earlier dbg_value referring to V,
+  /// generate the debug data structures now that we've seen its definition.
----------------
Please drop the `resolveDanglingDebugInfo -`


================
Comment at: test/DebugInfo/X86/sdag-ir-salvage.ll:5
+; can be salvaged back to the underlying argument vreg.
+
+; CHECK:   ![[AAAVAR:.*]] = !DILocalVariable(name: "aaa",
----------------
can you add a check for the next: label, too?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57694/new/

https://reviews.llvm.org/D57694