[PATCH] D57703: [AMDGPU] Consider XOR in waterfall loop as a terminator

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 4 11:55:20 PST 2019


arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/indirect-addressing-term.ll:1-19
+; RUN: llc -amdgpu-scalarize-global-loads=false -march=amdgcn -mcpu=tahiti -verify-machineinstrs -stop-after=expand-isel-pseudos < %s | FileCheck -check-prefixes=GCN %s
+; RUN: llc -amdgpu-scalarize-global-loads=false -march=amdgcn -mcpu=gfx900 -mattr=-flat-for-global -verify-machineinstrs -stop-after=expand-isel-pseudos < %s | FileCheck -check-prefixes=GCN %s
+
+; Verify that we consider the xor at the end of the waterfall loop emitted for
+; divergent indirect addressing as a terminator.
+
+declare i32 @llvm.amdgcn.workitem.id.x() #1
----------------
arsenm wrote:
> This test isn't really useful. -stop-after=isel and checking the MIR should work
Possibly -O0 could show something break


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57703/new/

https://reviews.llvm.org/D57703





More information about the llvm-commits mailing list