[PATCH] D57692: [DAG] BaseIndexOffset: FrameIndexSDNodes with the same FrameIndex compare equal.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 4 11:11:16 PST 2019


courbet added a comment.

In D57692#1383402 <https://reviews.llvm.org/D57692#1383402>, @niravd wrote:

> Do we have a case where this changes things? because it looks like it should be already handled by the trivial Base == Other.Base check.


It does allow the comparison between `FrameIndexSDNodes` with the same `FrameIndex`, one being a `TargetFrameIndex` and the other one being a `FrameIndex`, which are essentially the same thing as far as `BaseIndexOffset` is concerned AFAICT (only the type of produced value differs).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57692/new/

https://reviews.llvm.org/D57692





More information about the llvm-commits mailing list