[PATCH] D56715: X86DAGToDAGISel::matchBitExtract(): prepare 'control' in 32 bits

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 4 10:40:13 PST 2019


lebedev.ri added a comment.

In D56715#1383512 <https://reviews.llvm.org/D56715#1383512>, @craig.topper wrote:

> I don't think SimplifyDemandedBits can do anything for this. We're taking an i8 shift value and turning it into a control. The issue is entirely within how this code promoted that i8 value to match the width of the BEXTR/BZHI.
>
> LGTM


Thank you for the review.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56715/new/

https://reviews.llvm.org/D56715





More information about the llvm-commits mailing list