[PATCH] D57027: [AMDGPU] Factored PAL metadata handling out into its own class

[Tim Renouf via Phabricator via llvm-commits]

tpr marked an inline comment as done.
tpr added inline comments.


================
Comment at: lib/Target/AMDGPU/Utils/AMDGPUPALMetadata.h:85
+  // Write the accumulated PAL metadata as LLVM IR metadata. This is used by the
+  // frontend to pass the PAL metadata to the backend.
+  void writeToIR(Module *M, bool MsgPackFormat);
----------------
arsenm wrote:
> scott.linder wrote:
> > How is the front-end structured so that it has access to this header? I thought all of the headers in the AMDGPU target were private.
> They are
Right, I've got the frontend diving in and directly including the .h file from inside lib/Target/AMDGPU. Is that bad? Is that an argument for going back to putting this stuff, maybe excluding the parts used by codegen, in lib/BinaryFormat, or something?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57027/new/

https://reviews.llvm.org/D57027