[PATCH] D33041: [ELF] - Set DF_STATIC_TLS flag for x86_64 target.

Mon Feb 4 09:08:20 PST 2019

emaste added a comment.

In D33041#1382751 <https://reviews.llvm.org/D33041#1382751>, @grimar wrote:

> In D33041#1382592 <https://reviews.llvm.org/D33041#1382592>, @emaste wrote:
>
> > FreeBSD patch adding initial exec TLS mode for dynamically loaded shared objects: https://reviews.freebsd.org/D19072. Can we revisit this lld patch?
>
>
> I'll take a look tomorrow.

Great, thank you.

> Seems FreeBSD is going to use it for both x86_64 and i386 targets for start? That means we also might want to revisit D32354 <https://reviews.llvm.org/D32354>.
>  It was reverted.

Yes, we were still shipping GNU ld.bfd 2.17.50 as /usr/bin/ld on i386 until just recently because of trouble in the ports tree (although the kernel and base system userland has been linked with lld for quite some time).

Now that lld is fully enabled on amd64, i386, arm64 and armv7 we'll start making use of these features across platforms, i386 included.

> FTR and to answer the comment from freebsd.org page above, which was
>  "They did not stated why DF_STATIC_TLS was considered as 'not needed'.":
> 
> Rafael's answer in the mail list that time was:
> 
>> I just cloned musl and DF_STATIC_TLS is not used anywhere.
>> 
>> glibc used to use it, but doesn't since 2002
>>  (2430d57a13f4f10312e13c58962cd9104e6428fd).
>> 
>> It is also not used by the freebsd one.

Thank you for the archaeology; looking into what we'll do in FreeBSD.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D33041/new/

https://reviews.llvm.org/D33041