[PATCH] D57692: [DAG] BaseIndexOffset: FrameIndexSDNodes with the same FrameIndex compare equal.

[Clement Courbet via Phabricator via llvm-commits]

courbet created this revision.
courbet added a reviewer: niravd.
Herald added a subscriber: arphaman.
Herald added a project: LLVM.

Repository:
  rL LLVM

https://reviews.llvm.org/D57692

Files:
  lib/CodeGen/SelectionDAG/SelectionDAGAddressAnalysis.cpp


Index: lib/CodeGen/SelectionDAG/SelectionDAGAddressAnalysis.cpp
===================================================================
--- lib/CodeGen/SelectionDAG/SelectionDAGAddressAnalysis.cpp
+++ lib/CodeGen/SelectionDAG/SelectionDAGAddressAnalysis.cpp
@@ -59,17 +59,22 @@
 
     const MachineFrameInfo &MFI = DAG.getMachineFunction().getFrameInfo();
 
-    // Match non-equal FrameIndexes - If both frame indices are fixed
-    // we know their relative offsets and can compare them. Otherwise
-    // we must be conservative.
+    // Match FrameIndexes.
     if (auto *A = dyn_cast<FrameIndexSDNode>(Base))
-      if (auto *B = dyn_cast<FrameIndexSDNode>(Other.Base))
+      if (auto *B = dyn_cast<FrameIndexSDNode>(Other.Base)) {
+        // Equal FrameIndexes - offsets are directly comparable.
+        if (A->getIndex() == B->getIndex())
+          return true;
+        // Non-equal FrameIndexes - If both frame indices are fixed
+        // we know their relative offsets and can compare them. Otherwise
+        // we must be conservative.
         if (MFI.isFixedObjectIndex(A->getIndex()) &&
             MFI.isFixedObjectIndex(B->getIndex())) {
           Off += MFI.getObjectOffset(B->getIndex()) -
                  MFI.getObjectOffset(A->getIndex());
           return true;
         }
+      }
   }
   return false;
 }
@@ -195,4 +200,3 @@
 }
 
 #endif
-


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57692.185060.patch
Type: text/x-patch
Size: 1371 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190204/1f2b7d8c/attachment.bin>