[PATCH] D37461: [X86][AsmParser] re-introduce 'offset' operator

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

There are at least 3 things missing to get `check-clang` to work:

1. clang currently supports `offset localvar`, which cl.exe doesn't support. This is currently rewritten to the stack address; after this patch it instead becomes `offset localvar` but localvar isn't an existing symbol of course. So for locals, this would still have to do the rewrite.

2. For `offset Foo::bar`, clang used to rewrite that to a local symbol, not it just prints `offset Foo::bar` – I think we probably need to put the mangled name there instead.

3. For `  __asm mov [eax], offset var` we get `ambiguous operand size for instruction 'mov'` now; that needs fixing.

I don't know if I'll have time soon to look into these.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D37461/new/

https://reviews.llvm.org/D37461